Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii-client): expose grpc event messages #1826

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Apr 12, 2024

DOJ-358

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 70.14%. Comparing base (f6510d5) to head (d724239).

Files Patch % Lines
crates/torii/grpc/src/client.rs 0.00% 27 Missing ⚠️
crates/torii/client/src/client/mod.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
- Coverage   70.22%   70.14%   -0.09%     
==========================================
  Files         315      315              
  Lines       35566    35607      +41     
==========================================
  Hits        24977    24977              
- Misses      10589    10630      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added the torii label Apr 15, 2024
@Larkooo Larkooo force-pushed the torii-client-event-messages branch from 447d5b6 to d724239 Compare April 22, 2024 14:14
@glihm
Copy link
Collaborator

glihm commented Apr 22, 2024

If tests can be added here, good. If it's part of a larger refactoring for testing, good for subsequent PR.

@glihm glihm merged commit 10f7f9f into dojoengine:main Apr 22, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants