Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move class artifacts out of katana-primitives #1813

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 11, 2024

bcs the classes are used throughout other crates in /katana and not just in /primitives, so make sense to move it to the top dir

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (11e0881) to head (f1726db).

Files Patch % Lines
...ates/katana/core/src/service/messaging/ethereum.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1813   +/-   ##
=======================================
  Coverage   68.42%   68.43%           
=======================================
  Files         307      307           
  Lines       33834    33836    +2     
=======================================
+ Hits        23152    23155    +3     
+ Misses      10682    10681    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy
Copy link
Member Author

kariy commented Apr 11, 2024

Merge activity

  • Apr 11, 1:56 AM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • Apr 11, 1:56 AM EDT: @kariy merged this pull request with Graphite.

@kariy kariy merged commit 7257806 into main Apr 11, 2024
12 checks passed
@kariy kariy deleted the move-feature-contracts branch April 11, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant