feat: add metadata section to the world contract manifest #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lambda-0x and @RareSecond any approval/confirmation welcome. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
+ Coverage 68.42% 68.56% +0.13%
==========================================
Files 307 307
Lines 33834 33853 +19
==========================================
+ Hits 23152 23210 +58
+ Misses 10682 10643 -39 ☔ View full report in Codecov by Sentry. |
lambda-0x
approved these changes
Apr 10, 2024
glihm
commented
Apr 11, 2024
matzayonc
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: add metadata section to the world contract manifest * fix: fmt * fix: remove ignore on a manifest test * fix formatting --------- Co-authored-by: lambda-0x <[email protected]>
matzayonc
pushed a commit
that referenced
this pull request
Apr 14, 2024
* feat: add metadata section to the world contract manifest * fix: fmt * fix: remove ignore on a manifest test * fix formatting --------- Co-authored-by: lambda-0x <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding generation could be done by almost only the manifest as input.
As a request, here is a modification that adds some metadata to the manifest to obtain more context on what was done during deployment.
Doing so, the client can behaves differently based on the profile used + the RPC URL already embedded.