Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add better message for u256 being used as a key #1769

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Apr 4, 2024

More descriptive message to ensure the user knows why u256, which seem a core type as felt252, is not supported as a key into models.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.95%. Comparing base (09762ad) to head (d85512d).

Files Patch % Lines
crates/dojo-lang/src/model.rs 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         305      305              
  Lines       33640    33653      +13     
==========================================
+ Hits        22528    22531       +3     
- Misses      11112    11122      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit ba1b250 into dojoengine:main Apr 4, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant