Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure scarb compilation even when root package is missing #1759

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Apr 3, 2024

Scarb can be compiled without having a root package. To ensure compatibility for bindgen and library compilation, bindgen uses now a default NO_ROOT_PACKAGE in case it can't be found.

Closes #1758
Closes DOJ-320

Scarb can be compiled without having a root package.
To ensure compatibility for bindgen and library compilation,
bindgen uses now a default NO_ROOT_PACKAGE in case it can't be found.
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.85%. Comparing base (c595fc9) to head (ac14b42).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/dojo-lang/src/scarb_internal/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   67.81%   67.85%   +0.03%     
==========================================
  Files         304      304              
  Lines       33150    33164      +14     
==========================================
+ Hits        22482    22502      +20     
+ Misses      10668    10662       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 3e3b521 into dojoengine:main Apr 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sozo] sozo build fails with No root package name
1 participant