Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add #[dojo::event] attribute #1721

Merged
merged 16 commits into from
Mar 29, 2024
Merged

feat: add #[dojo::event] attribute #1721

merged 16 commits into from
Mar 29, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Mar 28, 2024 •
edited
Loading

INT-528

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.85714% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 68.75%. Comparing base (0b35400) to head (163d6be).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/dojo-lang/src/event.rs 82.00% 27 Missing ⚠️
crates/dojo-lang/src/plugin.rs 57.89% 8 Missing ⚠️
crates/dojo-lang/src/inline_macros/emit.rs 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   68.56%   68.75%   +0.18%     
==========================================
  Files         294      297       +3     
  Lines       31908    32507     +599     
==========================================
+ Hits        21879    22351     +472     
- Misses      10029    10156     +127

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo marked this pull request as ready for review March 28, 2024 22:04
@Larkooo Larkooo requested review from glihm, tarrencev and notV4l March 28, 2024 22:04
@Larkooo Larkooo changed the title feat: start working on dojo::event attr feat: add #[dojo::event] attribute Mar 28, 2024
glihm
glihm approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Larkooo, thanks for that mate.

@glihm glihm merged commit 5562553 into dojoengine:main Mar 29, 2024
12 checks passed
@notV4l notV4l mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

@tarrencev tarrencev Awaiting requested review from tarrencev

@notV4l notV4l Awaiting requested review from notV4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Larkooo @glihm