Feat(torii-grpc): support Events query #1567
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 70.06% 69.81% -0.26%
==========================================
Files 236 265 +29
Lines 22531 26718 +4187
==========================================
+ Hits 15786 18652 +2866
- Misses 6745 8066 +1321 ☔ View full report in Codecov by Sentry. |
crates/torii/grpc/proto/types.proto
Outdated
| @@ -45,6 +45,15 @@ message Entity { | |||
| repeated Model models = 2; | |||
| } | |||
|
|
|||
| message Event { | |||
| // The event's hashed keys | |||
| bytes hashed_keys = 1; | |||
There was a problem hiding this comment.
The hashed_keys is really just for entities, for events I think only input needed is repeated bytes keys. This mirrors graphql query.
There was a problem hiding this comment.
Actually message Event is used on the Response/output. OK, the output will display repeated bytes keys
crates/torii/grpc/proto/types.proto
Outdated
| @@ -84,10 +99,21 @@ message Clause { | |||
| } | |||
| } | |||
|
|
|||
| message EventClause { | |||
| oneof event_clause_type { | |||
| HashedKeysClause hashed_keys = 1; | |||
There was a problem hiding this comment.
Same here, hashed_keys can be omitted. Probably EventClause is not needed.
There was a problem hiding this comment.
Thanks for your reply. Gonna work on it
There was a problem hiding this comment.
Fixed on dcaa4e0
Co-authored-by: Yun <[email protected]>
Co-authored-by: Yun <[email protected]>
gianalarcon
changed the title
Fixed on commit 7e09a0c |
Closes #1420
Hi @broody Please check my Events query implementation. Waiting for your feedback