Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana-provider): fix how latest block number/hash is retrieved from db #1475

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 24, 2024

No description provided.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (df68436) 69.40% compared to head (6da3bb4) 69.44%.
Report is 2 commits behind head on main.

Files Patch % Lines
crates/katana/core/src/service/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   69.40%   69.44%   +0.04%     
==========================================
  Files         228      228              
  Lines       22138    22138              
==========================================
+ Hits        15364    15373       +9     
+ Misses       6774     6765       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev
Copy link
Contributor

Can we add a quick test for this? Generally, it's a good practice to write tests for regressions

@kariy
Copy link
Member Author

kariy commented Jan 25, 2024

Can we add a quick test for this? Generally, it's a good practice to write tests for regressions

Added some asserts in the provider tests.

The Error: Missing block header for block number 0 bug seems to be caused by this issue and also #1477.

@tarrencev tarrencev merged commit 6233fa5 into dojoengine:main Jan 25, 2024
12 checks passed
@kariy kariy deleted the katana-db-fix branch January 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants