Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torii] Debug output of all indexed Events #1464

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

dubzn
Copy link
Contributor

@dubzn dubzn commented Jan 19, 2024

Description

Display through debug!() the events that are not caught by the defined processors. The keys and data of the event are shown in hexadecimal values.

Closes: #1421

Screencast.from.19-01-24.15_28_52.mp4

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 605 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (a55e227) 70.59%.
Report is 26 commits behind head on main.

Files Patch % Lines
bin/katana/src/main.rs 0.00% 94 Missing ⚠️
crates/katana/runner/src/logs.rs 10.00% 72 Missing ⚠️
bin/saya/src/main.rs 0.00% 56 Missing ⚠️
crates/saya/core/src/lib.rs 0.00% 50 Missing ⚠️
crates/katana/primitives/src/genesis/mod.rs 92.40% 35 Missing ⚠️
bin/saya/src/args/mod.rs 0.00% 33 Missing ⚠️
...es/saya/core/src/data_availability/celestia/mod.rs 0.00% 33 Missing ⚠️
crates/katana/runner/src/prefunded.rs 0.00% 31 Missing ⚠️
bin/saya/src/args/data_availability.rs 0.00% 24 Missing ⚠️
bin/sozo/src/ops/migration/mod.rs 30.30% 23 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
+ Coverage   70.06%   70.59%   +0.52%     
==========================================
  Files         236      257      +21     
  Lines       22531    24933    +2402     
==========================================
+ Hits        15786    17601    +1815     
- Misses       6745     7332     +587     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev
Copy link
Contributor

Hm I feel like trace! might be more appropriate here

@glihm glihm merged commit 58a50d1 into dojoengine:main Feb 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Torii] Debug output of all indexed Events
5 participants