Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: libp2p relay and gossipsub server #1459

Merged
merged 36 commits into from
Jan 25, 2024
Merged

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Jan 18, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (3620d72) 68.03% compared to head (fbe2874) 69.83%.
Report is 8 commits behind head on main.

Files Patch % Lines
crates/torii/client/src/client/mod.rs 0.00% 23 Missing ⚠️
crates/torii/libp2p/src/server/mod.rs 91.93% 15 Missing ⚠️
crates/torii/libp2p/src/client/mod.rs 91.44% 13 Missing ⚠️
bin/torii/src/main.rs 0.00% 11 Missing ⚠️
crates/torii/libp2p/src/server/events.rs 69.23% 4 Missing ⚠️
crates/torii/libp2p/src/client/events.rs 90.00% 1 Missing ⚠️
crates/torii/libp2p/src/errors.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
+ Coverage   68.03%   69.83%   +1.80%     
==========================================
  Files         228      235       +7     
  Lines       22074    22587     +513     
==========================================
+ Hits        15017    15773     +756     
+ Misses       7057     6814     -243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy marked this pull request as ready for review January 19, 2024 02:55
@kariy kariy marked this pull request as draft January 19, 2024 06:27
@Larkooo Larkooo marked this pull request as ready for review January 19, 2024 19:58
@Larkooo Larkooo requested a review from tarrencev January 23, 2024 17:49
@Larkooo Larkooo requested a review from broody January 23, 2024 17:50
bin/torii/src/main.rs Outdated Show resolved Hide resolved
crates/torii/client/src/client/error.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/Cargo.toml Outdated Show resolved Hide resolved
crates/torii/libp2p/src/client/mod.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/src/client/mod.rs Outdated Show resolved Hide resolved
crates/torii/client/src/client/mod.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/src/client/mod.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/src/client/mod.rs Outdated Show resolved Hide resolved
@Larkooo Larkooo requested a review from glihm January 24, 2024 20:58
@Larkooo
Copy link
Collaborator Author

Larkooo commented Jan 24, 2024

@glihm would be great if you could take a look at some of the event loop and channel stuff to see if anything looks odd. does taking commands from a channel make sense? that solves most of the borrow checker issues when running the client.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Larkooo. 🚀

Some minor refacto comments to anticipate future PRs.

About the channels, it looks good to me. We've to keep in mind the way unbounded aborts the process (when out of memory), this to ensure we can identify a possible error cause in the future associated to that.

Would be happy to dive into the borrow checker issues you had to understand how you reached the channel. 👍

crates/torii/libp2p/Cargo.toml Outdated Show resolved Hide resolved
crates/torii/libp2p/src/client/mod.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/src/server/mod.rs Outdated Show resolved Hide resolved
crates/torii/libp2p/src/server/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and nice addition for the CommandSender.
Will you add the run_libp2p in this run, or is it a work for the next PR?

@Larkooo
Copy link
Collaborator Author

Larkooo commented Jan 25, 2024

Thanks for the update and nice addition for the CommandSender. Will you add the run_libp2p in this run, or is it a work for the next PR?

It has been added, pretty simple, just awaits the event_loop.run(). it's in torii-client. I think for now that's good enough

@glihm
Copy link
Collaborator

glihm commented Jan 25, 2024

Thanks for the update and nice addition for the CommandSender. Will you add the run_libp2p in this run, or is it a work for the next PR?

It has been added, pretty simple, just awaits the event_loop.run(). it's in torii-client. I think for now that's good enough

Oh ok, I was referring to the version we've seen yesterday. All good!

@tarrencev tarrencev merged commit 09783a4 into dojoengine:main Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants