-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: libp2p relay and gossipsub server #1459
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
+ Coverage 68.03% 69.83% +1.80%
==========================================
Files 228 235 +7
Lines 22074 22587 +513
==========================================
+ Hits 15017 15773 +756
+ Misses 7057 6814 -243 ☔ View full report in Codecov by Sentry. |
@glihm would be great if you could take a look at some of the event loop and channel stuff to see if anything looks odd. does taking commands from a channel make sense? that solves most of the borrow checker issues when running the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Larkooo. 🚀
Some minor refacto comments to anticipate future PRs.
About the channels, it looks good to me. We've to keep in mind the way unbounded
aborts the process (when out of memory), this to ensure we can identify a possible error cause in the future associated to that.
Would be happy to dive into the borrow checker issues you had to understand how you reached the channel. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and nice addition for the CommandSender
.
Will you add the run_libp2p
in this run, or is it a work for the next PR?
It has been added, pretty simple, just awaits the event_loop.run(). it's in torii-client. I think for now that's good enough |
Oh ok, I was referring to the version we've seen yesterday. All good! |
No description provided.