Refactor torii graphql object traits #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
+ Coverage 68.49% 68.68% +0.18%
==========================================
Files 220 220
Lines 21714 21593 -121
==========================================
- Hits 14874 14831 -43
+ Misses 6840 6762 -78 ☔ View full report in Codecov by Sentry. |
broody
force-pushed
the
refactor-gql-object-trait
branch
from
12572d6 to
fe1d226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ObjectTraitwas used for both resolvable (Transaction, Entity, etc) and not resolvable (PageInfo, Connection, etc) graphql objects. This PR refactors it intoBasicObjectandResolvableObjectand reduces some code duplication for resolvers.