Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(katana): historical block execution context #1436

Merged
merged 1 commit into from
Jan 16, 2024
Merged

refactor(katana): historical block execution context #1436

merged 1 commit into from
Jan 16, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 14, 2024

Resolves #1347

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev/katana@c6b29da). Click here to learn what that means.

Additional details and impacted files 
@@              Coverage Diff              @@
##             dev/katana    #1436   +/-   ##
=============================================
  Coverage              ?   68.35%           
=============================================
  Files                 ?      220           
  Lines                 ?    21584           
  Branches              ?        0           
=============================================
  Hits                  ?    14754           
  Misses                ?     6830           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy force-pushed the 1347-historical-block-context branch from 39d7f06 to 861f565 Compare January 15, 2024 07:06
@kariy kariy mentioned this pull request Jan 15, 2024
Merged
@kariy kariy force-pushed the 1347-historical-block-context branch from 90dedc9 to 156ddca Compare January 15, 2024 11:49
glihm
glihm approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on that, let's move forward as you mentioned and I'll get more context on it for subsequent PRs too. 👍

@kariy kariy merged commit 5031257 into dev/katana Jan 16, 2024
10 checks passed
@kariy kariy deleted the 1347-historical-block-context branch January 16, 2024 06:52
@kariy kariy restored the 1347-historical-block-context branch January 16, 2024 07:06
@kariy kariy deleted the 1347-historical-block-context branch January 16, 2024 07:06
@kariy kariy mentioned this pull request Jan 16, 2024
Merged
kariy added a commit that referenced this pull request Jan 17, 2024
@kariy
refactor(katana): historical block execution context (#1436)
3287ffa 
Resolves #1347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kariy @codecov-commenter @glihm