Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v0.5.0 #1430

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Prepare release: v0.5.0 #1430

merged 1 commit into from
Jan 12, 2024

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Jan 12, 2024

Tagging a minor version here since there is a breaking change in #1410 and the v1 accounts

Lmk if you guys are cool with this

@tarrencev tarrencev requested review from glihm, broody and kariy January 12, 2024 18:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (942d895) 67.55% compared to head (42832de) 67.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         218      218           
  Lines       21011    21012    +1     
=======================================
+ Hits        14195    14196    +1     
  Misses       6816     6816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this.

The only drawback I see and checked with @broody last time is that starkli users will no longer be able to use --account katana-x as we don't support RPC 0.6.0 for now so we can't PR starkli.

But let's give support for this on discord/TG if required to have the dojo stack going forward as with sozo is going fine.

@kariy let's catch up on rpc 0.6.0, even if starknet-js is being very slow to make the step for the stable version, let's prepare the terrain on our side.

@broody
Copy link
Collaborator

broody commented Jan 12, 2024

Yup, les do it!

@tarrencev tarrencev merged commit 41a48b8 into main Jan 12, 2024
12 checks passed
@tarrencev tarrencev deleted the prepare-release branch January 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants