Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sozo/account): legacy bool flag to use old calldata encoding #1419

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

lambda-0x
Copy link
Contributor

@lambda-0x lambda-0x commented Jan 11, 2024

fix: #1418

improvements TODO:

  • in KatanaRunner Command expects the full path of binary
  • katana's logs should be written to a temporary folder

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3fd7f3c) 67.41% compared to head (3e84999) 67.55%.

Files Patch % Lines
crates/sozo/src/commands/options/account.rs 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   67.41%   67.55%   +0.14%     
==========================================
  Files         218      218              
  Lines       20978    21011      +33     
==========================================
+ Hits        14142    14195      +53     
+ Misses       6836     6816      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x marked this pull request as draft January 11, 2024 21:18
@lambda-0x lambda-0x marked this pull request as ready for review January 11, 2024 22:14
@lambda-0x
Copy link
Contributor Author

(git woopsie)

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hack for testing the actual encoding.

crates/sozo/src/commands/options/account.rs Show resolved Hide resolved
crates/sozo/src/commands/options/account.rs Outdated Show resolved Hide resolved
crates/sozo/src/commands/options/account.rs Show resolved Hide resolved
@glihm glihm merged commit 942d895 into dojoengine:main Jan 12, 2024
10 checks passed
@lambda-0x lambda-0x deleted the legacy-calldata branch January 12, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SOZO] Add a flag to support legacy encoding
4 participants