-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example spawn-and-move #1413
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
=======================================
Coverage 67.62% 67.63%
=======================================
Files 218 218
Lines 21060 21060
=======================================
+ Hits 14242 14243 +1
+ Misses 6818 6817 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that @dpinones! Good fresh cairo code on enums was definitely needed.
Could you run the README flow again using the latest Katana (built on main) and adjust the variables to it? I've left one comment on a important spot (the Scarb manifest), but you may need to adjust more in the README as addresses will change.
This because you're surely using the Katana from v0.4.4
and you should be using new accounts addresses for that as this will be included in the next release. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @dpinones!
spawn-and-move
based on the dojo-starter repository.