Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model query field to camel case #1408

Conversation

JunichiSugiura
Copy link
Contributor

@JunichiSugiura JunichiSugiura commented Jan 9, 2024

World explorer currently expects lower camel case model fields

Screenshot 2024-01-09 at 13 00 26

@JunichiSugiura JunichiSugiura force-pushed the fix(torii)/model-query-casing branch from 4b675c4 to 7490851 Compare January 9, 2024 17:56
@JunichiSugiura JunichiSugiura force-pushed the fix(torii)/model-query-casing branch from 7490851 to c1ac18f Compare January 9, 2024 19:11
@JunichiSugiura
Copy link
Contributor Author

I cannot reproduce the CI error locally. Instead, I see totally different error on my machine. Neither doesn't seem related to my change. I wonder if I miss something here... @broody

error on my machine

--- STDERR:              torii-graphql tests::models_test::tests::models_test ---
thread 'tests::models_test::tests::models_test' panicked at 'called `Result::unwrap()` on an `Err` value: Provider(StarknetError(StarknetErrorWithMessage { code: Known(ContractError), message: "Contract error" }))', crates/torii/graphql/src/tests/mod.rs:266:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@JunichiSugiura
Copy link
Contributor Author

oh my branch is way behind. let me re-create the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant