Upgrade rust to 1.74.0

[fishseabowl]

This PR fixed the issue "Github Action for cargo-udeps failed" as mentioned in issue #1364

[glihm]

Hey @fishseabowl thanks for the contribution here!

Would appreciate your input on the discussion started on the issue. 👍

Fixes #1407.

[kariy]

Don't forget to change it in the release ci as well

dojo/.github/workflows/release.yml

Line 11 in 3bb35a6

RUST_VERSION: 1.70.0

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fd7f3c) 67.41% compared to head (89b38d0) 67.41%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1365   +/-   ##
=======================================
  Coverage   67.41%   67.41%           
=======================================
  Files         218      218           
  Lines       20978    20978           
=======================================
  Hits        14142    14142           
  Misses       6836     6836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fishseabowl]

Don't forget to change it in the release ci as well

dojo/.github/workflows/release.yml

Line 11 in 3bb35a6

RUST_VERSION: 1.70.0

Thanks for your reminder. Has changed.

[fishseabowl]

Hello @kariy, could you please take a look at the reported errors? It mentions that: = note: the wasm32-unknown-unknown target may not be installed in ci/ensure-wasm, and error: 'cargo-clippy' is not installed for the toolchain '1.74.0-x86_64-unknown-linux-gnu' in ci/clippy, even though it's installed in the Dockerfile.

[glihm]

Hello @kariy, could you please take a look at the reported errors? It mentions that: = note: the wasm32-unknown-unknown target may not be installed in ci/ensure-wasm, and error: 'cargo-clippy' is not installed for the toolchain '1.74.0-x86_64-unknown-linux-gnu' in ci/clippy, even though it's installed in the Dockerfile.

Don't we need to publish an updated version of the dev container to match the toolchain version bump? Because for the build, toolchains are automatically downloaded if not present on the system. But components may be adjusted in this case.

[glihm]

@kariy @tarrencev does something like this makes sense #1411?

The idea is to be able to push some devcontainer updates without directly relying on the rust-toolchain file, which may affect the whole building system, only to have the good version to release devcontainer (as it seems to be the case now).

Never made devcontainer release, I'm perhaps missing something.

WDYT?

[fishseabowl]

Hello @kariy, could you please take a look at the reported errors? It mentions that: = note: the wasm32-unknown-unknown target may not be installed in ci/ensure-wasm, and error: 'cargo-clippy' is not installed for the toolchain '1.74.0-x86_64-unknown-linux-gnu' in ci/clippy, even though it's installed in the Dockerfile.

Don't we need to publish an updated version of the dev container to match the toolchain version bump? Because for the build, toolchains are automatically downloaded if not present on the system. But components may be adjusted in this case.

@glihm Yes, the dev container will automatically match the rust-toolchain version, as shown in the following code:

dojo/.devcontainer/Dockerfile

Lines 19 to 22 in 3bb35a6

	RUN rustup toolchain install $(cat rust-toolchain.toml | grep channel | cut -d\" -f2) && \
	rustup default $(cat rust-toolchain.toml | grep channel | cut -d\" -f2) && \
	rustup component add clippy && \
	rustup component add rustfmt

However, the ci/wasm and ci/clippy processes report errors related to uninstalled components, which seems strange.

[glihm]

Hello @kariy, could you please take a look at the reported errors? It mentions that: = note: the wasm32-unknown-unknown target may not be installed in ci/ensure-wasm, and error: 'cargo-clippy' is not installed for the toolchain '1.74.0-x86_64-unknown-linux-gnu' in ci/clippy, even though it's installed in the Dockerfile.

Don't we need to publish an updated version of the dev container to match the toolchain version bump? Because for the build, toolchains are automatically downloaded if not present on the system. But components may be adjusted in this case.

@glihm Yes, the dev container will automatically match the rust-toolchain version, as shown in the following code:

dojo/.devcontainer/Dockerfile

Lines 19 to 22 in 3bb35a6

	RUN rustup toolchain install $(cat rust-toolchain.toml | grep channel | cut -d\" -f2) && \
	rustup default $(cat rust-toolchain.toml | grep channel | cut -d\" -f2) && \
	rustup component add clippy && \
	rustup component add rustfmt

However, the ci/wasm and ci/clippy processes report errors related to uninstalled components, which seems strange.

Yup, in the meantime, @fishseabowl could you try with this image? glihm/dojo:1.74.0
I just built it with the according toolchain version to validate #1411.
https://hub.docker.com/r/glihm/dojo

[tarrencev]

@kariy @tarrencev does something like this makes sense #1411?

The idea is to be able to push some devcontainer updates without directly relying on the rust-toolchain file, which may affect the whole building system, only to have the good version to release devcontainer (as it seems to be the case now).

Never made devcontainer release, I'm perhaps missing something.

WDYT?

yup that makes sense!

[glihm]

@fishseabowl actually can you update with the new version of the dojo container?
https://github.com/dojoengine/dojo/pkgs/container/dojo-dev/165725993?tag=136a67a

[fishseabowl]

@fishseabowl actually can you update with the new version of the dojo container? https://github.com/dojoengine/dojo/pkgs/container/dojo-dev/165725993?tag=136a67a

@glihm Yes. Done. Thank you for your help!

[glihm]

@fishseabowl do appreciate you've started all the work on this bump and identified the root reason.

The changes to the container triggered the auto PR that at the end is covering 100% of this PR. Apologize for that, I didn't had enough perspective to detect this earlier.

I'll close this one for now, thanking you again for the time dedicated to this.