Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose order params #1332

Merged
merged 18 commits into from
Jan 5, 2024
Merged

Expose order params #1332

merged 18 commits into from
Jan 5, 2024

Conversation

gianalarcon
Copy link
Contributor

@gianalarcon gianalarcon commented Dec 27, 2023 •
edited
Loading

Closes #1255

  • Implement ModelObject struct. Create fn new() for ModelObject
  • No direction input value for World__ModelOrder
  • Implement fn resolve_many() for ModelObject

@broody

@gianalarcon gianalarcon changed the title Models order Expose order params Dec 27, 2023
@gianalarcon gianalarcon marked this pull request as ready for review January 4, 2024 07:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (319c985) 65.96% compared to head (2cc3c38) 67.10%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
+ Coverage   65.96%   67.10%   +1.14%     
==========================================
  Files         228      231       +3     
  Lines       19859    20858     +999     
==========================================
+ Hits        13100    13997     +897     
- Misses       6759     6861     +102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

broody
broody reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@broody broody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things

crates/torii/graphql/src/object/connection/mod.rs Outdated Show resolved Hide resolved
crates/torii/graphql/src/tests/models_ordering_test.rs Outdated Show resolved Hide resolved
@broody broody merged commit 74c12c0 into dojoengine:main Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broody broody broody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose order params for World__ModelConnection
3 participants
@gianalarcon @codecov-commenter @broody