Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torii grpc member clause query #1312

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Torii grpc member clause query #1312

merged 1 commit into from
Dec 19, 2023

Conversation

broody
Copy link
Collaborator

@broody broody commented Dec 19, 2023

Grpc member query endpoint example:

"query": {
    "clause": {
        "member": {
            "member": "remaining",
            "model": "Moves",
            "operator": "LTE",
            "value": {
                "uint_value": "5"
            }
        }
    },
    "limit": 1,
    "offset": 0
}

Will followup with tests for all query clause types.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (85e92c3) 59.26% compared to head (63711c5) 59.09%.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 0.00% 41 Missing ⚠️
crates/torii/grpc/src/types/mod.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   59.26%   59.09%   -0.17%     
==========================================
  Files         225      225              
  Lines       18895    18948      +53     
==========================================
  Hits        11198    11198              
- Misses       7697     7750      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broody broody force-pushed the grpc-members-query branch from 44f6171 to 63711c5 Compare December 19, 2023 04:19
@tarrencev tarrencev merged commit c6dab67 into main Dec 19, 2023
11 checks passed
@tarrencev tarrencev deleted the grpc-members-query branch December 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants