Implement Katana Runner in Dojo #1205
Conversation
tarrencev
force-pushed
the
main
branch
7 times, most recently
from
6fa9022 to
ed21620
Compare
matzayonc
force-pushed
the
2-katana-runner
branch
from
a28dd33 to
cf687a3
Compare
There was a problem hiding this comment.
the katana runner shouldn't need to introduce a new binary. we already build on as part of katana. the runner should be a simple rust library that calls the katana binary through the shell, supports configuring cli (can all be default for the initial impl), handles forwarding logs to stderr and tears down the instance when it goes out of scope
.github/workflows/ci.yml
Outdated
| @@ -78,7 +78,8 @@ jobs: | |||
| toolchain: ${{ env.RUST_VERSION }} | |||
| - uses: Swatinem/rust-cache@v2 | |||
| - uses: arduino/setup-protoc@v2 | |||
| - run: cargo run --bin sozo -- --manifest-path crates/dojo-core/Scarb.toml test | |||
| - run: curl -L https://install.dojoengine.org | bash && source /home/runner/.bashrc && echo $PATH && /home/runner/.config/.dojo/bin/dojoup | |||
There was a problem hiding this comment.
perhaps it makes sense to use the dojo docker image for this job? it comes with katana installed
There was a problem hiding this comment.
That definitely makes sense.
By the way I noticed that dojoup is downloaded to /home/runner/.config/.dojo/bin/dojoup, not sure if it's the expected behaviour
.github/workflows/ci.yml
Outdated
| @@ -26,6 +26,12 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Install nextest test runner | |||
| uses: taiki-e/install-action@nextest | |||
|
|
|||
| - name: Build and run dev container task | |||
| uses: devcontainers/[email protected] | |||
There was a problem hiding this comment.
hm can we use the prebuilt one? we might have to update it (and eventually automate it)
There was a problem hiding this comment.
sure, just trying it out for now
matzayonc
force-pushed
the
2-katana-runner
branch
2 times, most recently
from
c16d112 to
0f973d0
Compare
tarrencev
force-pushed
the
main
branch
2 times, most recently
from
dd36cf5 to
4979471
Compare
tarrencev
force-pushed
the
2-katana-runner
branch
2 times, most recently
from
f583481 to
6242f7f
Compare
matzayonc
force-pushed
the
2-katana-runner
branch
from
f6020d4 to
58e4420
Compare
tarrencev
force-pushed
the
main
branch
3 times, most recently
from
87475da to
112cce7
Compare
tarrencev
force-pushed
the
2-katana-runner
branch
5 times, most recently
from
ee9e365 to
4e0407c
Compare
tarrencev
force-pushed
the
2-katana-runner
branch
from
4e0407c to
1a41979
Compare
tarrencev
force-pushed
the
main
branch
5 times, most recently
from
6a784ce to
a08f2cb
Compare
tarrencev
force-pushed
the
2-katana-runner
branch
from
4d441bf to
ef7cbf3
Compare
fixes neotheprogramist#2