Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Graphql test #1204

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Update Graphql test #1204

merged 4 commits into from
Nov 26, 2023

Conversation

gianalarcon
Copy link
Contributor

@gianalarcon gianalarcon commented Nov 24, 2023

Resolves #1103

Hi @broody , let me know if I am going in the right way

@broody
Copy link
Collaborator

broody commented Nov 25, 2023

Ah I was thinking to just to remove model_fixtures and use spinup_types_test like entites/models. But this will work too, tho maybe use Subrecord instead of Record for ur tests, recreating all that ty is probably not necessary.

@gianalarcon
Copy link
Contributor Author

gianalarcon commented Nov 25, 2023

Ok. Now I use Subrecord and Record(recreating just some of the ty).
I used to get errors implementing spinup_types_test like entites/models.

@gianalarcon gianalarcon marked this pull request as ready for review November 25, 2023 14:17
@broody broody merged commit e6a870f into dojoengine:main Nov 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Torii] Remove spawn-and-move dependency from graphql subscription test
2 participants