-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torii grpc entities query #1196
Conversation
Merge branch 'toriigrpc2-broody' into toriigrpc2
199b111
to
2cb0bf5
Compare
2cb0bf5
to
7f4d902
Compare
1dc6544
to
beb6801
Compare
schemas: RwLock<HashMap<ModelName, Ty>>, | ||
} | ||
|
||
impl ModelCache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will eventually need a way to invalidate a cache entry when we index an update to an existing model. Lets create an issue to track it
global_tables.extend(tables); | ||
} | ||
|
||
// TODO: Fallback to subqueries, SQLite has a max limit of 64 on 'table 'JOIN' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine to return an error in this case. 64 joins is a reasonable limit
@@ -31,7 +33,7 @@ pub struct KeysClause { | |||
#[derive(Debug, Serialize, Deserialize, PartialEq, Hash, Eq, Clone)] | |||
pub struct AttributeClause { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also rename this to MemberClause in a future PR
This PR exposes a
RetrieveEntities
grpc api, only implemented querying by keys clause, querying by attribute and composite clause to be implemented.Also,
map_row_to_ty
method is not currently used, will eventually be used by graphqlQuery format is similar to graphql, supply keys array and it will return all entities matching those keys. For wildcard, leave key part blank. Only pagination supported is limit offset.
Return format