torii: validate events #1100
Merged
torii: validate events #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notV4l
commented
Oct 25, 2023
notV4l
commented
- validate that events are emitted by world by checking event.keys.len()
tarrencev
reviewed
Oct 25, 2023
| @@ -17,6 +18,18 @@ where | |||
| { | |||
| fn event_key(&self) -> String; | |||
|
|
|||
| fn validate(&self, event: &Event) -> bool { | |||
There was a problem hiding this comment.
Hmm I think we should enforce this in each event processor so it can be done in the context of a particular event. We might want to define more keys on the starknet events for more efficient querying over rpc
notV4l
force-pushed
the
torii_validate_events
branch
from
2ef1013 to
a0e9f85
Compare
tarrencev
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.