Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic: test constraints #1099

Closed
wants to merge 1 commit into from

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Oct 25, 2023

chore: clippy/fmt
semantic: test constraints

Minor updates to add semantic test constraints like get! should return a tail and correct inputs should not result in diagnostic errors.

Helps to enforce the constraints are met and CAIRO_FIX_TESTS with incorrect semantics doesn't make failing tests pass.

@shramee shramee force-pushed the semantic-test-constraints branch 2 times, most recently from c4a0f91 to 54a24ad Compare October 25, 2023 06:40
@shramee shramee force-pushed the semantic-test-constraints branch from 54a24ad to c1aa7fd Compare October 25, 2023 06:51
@tarrencev
Copy link
Contributor

Hmm I think these cases should actually be explicitly tested in the semantics test. We should have test cases in the test_data that result in expected diagnostics

@shramee
Copy link
Contributor Author

shramee commented Oct 26, 2023

That does happen, but it can be easily changed to potentially incorrect ones with CAIRO_FIX_TESTS.

@tarrencev
Copy link
Contributor

Hm but the generated outputs should be verified in the pull request, thats the point of the snapshot tests

@shramee shramee closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants