Fix Torii graphql type name collision

[gianalarcon]

Resolves #1032

Redefine graphql types like {Model}_{CustomType/NestedType}

type Record {
  type_contract_address: ContractAddress
  type_nested: Record_Nested
}

type Record_Nested {
 depth: u8,
 type_number: u8,
}

It is working for some queries, but for some of them it is failing
Reason is GraphQL query returned errors: [ServerError { message: "error returned from database: (code: 1) no such table: Record$Record_Nested

Indeed we have Record$Nested table, but we dont have Record$Record_Nested table.

So the side effect to redefine names of graphql types is that we have rename as well some tables names on our database.

@broody I am going on the right way? Any suggestion about this? Thanks

[broody]

Looks like good way to do it. Instead of renaming, perhaps we could remove the prefix here when constructing the table name for nested type:

dojo/crates/torii/graphql/src/object/model_data.rs

Line 160 in d7f4650

let table_name = path_array.join("$");

[gianalarcon]

Looks like good way to do it. Instead of renaming, perhaps we could remove the prefix here when constructing the table name for nested type:

dojo/crates/torii/graphql/src/object/model_data.rs

Line 160 in d7f4650

let table_name = path_array.join("$");

I see, so, for this example, for current Record$Nested table name, we have to change into Record_Nested table name, right?
We dont have to use path_array.join() anymore is it?

[broody]

I see, so, for this example, for current Record$Nested table name, we have to change into Record_Nested table name, right? We dont have to use path_array.join() anymore is it?

I mean let's avoid renaming table and just remove prefix in path array. For example, the doubly nested member NestedMore, new path array with ur current change would be ["Record", "Record_Nested", "Record_NestedMore"], just need to transform it to match table name Record$Nested$NestedMore

[gianalarcon]

@broody I think I am done. Please check here.
I just left some prints in case I need. After you approved this PR I will remove them.

[broody]

Working good, just some suggestions to provide more context

[gianalarcon]

Hi @broody. I added your suggestions, indeed they are meaningful and useful for developer documentation