fix: artifacts naming issues #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notV4l
commented
Oct 13, 2023
notV4l
commented
- fix [sozo] naming conflicts between Components & Systems #930
- fix [sozo] Systems name & artifact naming #931
kariy
reviewed
Oct 13, 2023
There was a problem hiding this comment.
do you mind extending the test_compiler test in this file to check that the generated artifacts have the expected naming format?
crates/dojo-lang/src/compiler.rs
Outdated
Comment on lines
98
to
114
| let is_model = match class.abi.clone() { | ||
| Some(abii) => abii.items.iter().any(|i| match i { | ||
| abi::Item::Struct(s) => s.name == "dojo::database::schema::Struct", | ||
| _ => false, | ||
| }), | ||
| None => false, | ||
| }; |
There was a problem hiding this comment.
is this a reliable way to check for model/contract ?
tarrencev
force-pushed
the
main
branch
2 times, most recently
from
0f4d258 to
19d76ce
Compare
kariy
force-pushed
the
artifacts_naming
branch
from
38f06e6 to
1ed3903
Compare
kariy
force-pushed
the
artifacts_naming
branch
from
1ed3903 to
84cc19c
Compare
kariy
reviewed
Oct 26, 2023
|
|
||
| let mut file = target_dir.open_rw(file_name.clone(), "output file", ws.config())?; | ||
| let is_model = match &class.abi { | ||
| Some(abi) => abi.items.iter().any(|i| match i { |
There was a problem hiding this comment.
Recent update to Cairo 2.3.0 seems to have made items private which invalidates this approach.
There was a problem hiding this comment.
Added a solution here: starkware-libs/cairo#4310
|
i think there'll be an issue in the mapping here as well dojo/crates/dojo-lang/src/compiler.rs Line 99 in 1018840 similar contracts name would simply overwrite each other |
|
this still alive? |
tarrencev
force-pushed
the
main
branch
9 times, most recently
from
dd36cf5 to
4979471
Compare
tarrencev
force-pushed
the
main
branch
3 times, most recently
from
87475da to
112cce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.