Skip to content

Commit

Permalink
fix: add script to teardown tests and updated cargo lock (#1707)
Browse files Browse the repository at this point in the history
  • Loading branch information
glihm authored Mar 26, 2024
1 parent 5340720 commit a4ccc2e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
kind = "DojoContract"
class_hash = "0x5f0a221b80b5667c20574d62953f99eb6ddf7d351f531a9f0c56f96adb0d48b"
class_hash = "0xf6347423d9f59912d0b441646d448f5d4d30869e634061670e090266a41d0d"
abi = "abis/base/contracts/records.json"
reads = []
writes = []
Expand Down
8 changes: 8 additions & 0 deletions scripts/teardown_test_artifacts.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

# When tests are run, the `build.rs` of `dojo-test-utils` is re-building the
# cairo artifacts ONLY if they don't exist.
# This script gives an easy way to remove those artifacts.

rm -rf examples/spawn-and-move/target
rm -rf crates/torii/types-test/target

2 comments on commit a4ccc2e

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: a4ccc2e Previous: 4af8b03 Ratio
decompress world contract 17774843 ns/iter (± 207659) 966479 ns/iter (± 69770) 18.39

This comment was automatically generated by workflow using github-action-benchmark.

CC: @kariy @glihm @tarrencev

@glihm
Copy link
Collaborator Author

@glihm glihm commented on a4ccc2e Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark. Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: a4ccc2e Previous: 4af8b03 Ratio
decompress world contract 17774843 ns/iter (± 207659) 966479 ns/iter (± 69770) 18.39
This comment was automatically generated by workflow using github-action-benchmark.

CC: @kariy @glihm @tarrencev

@kariy do you have an idea of what could cause such difference? The world has not changed much in size.

Please sign in to comment.