This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
feat: add ModelDefinition to Dojo Model #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
remybar
force-pushed
the
feat-add_model_definition
branch
4 times, most recently
from
9d2e9c2 to
00792f3
Compare
…ors (dojoengine#25) * fix: remove base and dojo_init -> constructor * fix: fix cairo test for dojo_init
remybar
force-pushed
the
feat-add_model_definition
branch
from
00792f3 to
6ddbb72
Compare
glihm
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
definition()function to Dojo models to be able to retrieve the fullModelDefinitionat once instead of calling several functions to get each element one by one.