Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD tag is hardcoded in cell method #651

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TD tag is hardcoded in cell method #651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce25e6
explicit use of tag name td replaced with dojo/query call to allow fo…
speich Jul 5, 2013
af968f5
removed some unused variables
speich Jul 11, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions Grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define(["dojo/_base/kernel", "dojo/_base/declare", "dojo/on", "dojo/has", "put-selector/put", "./List", "dojo/_base/sniff"],
function(kernel, declare, listen, has, put, List){
define(["dojo/_base/kernel", "dojo/_base/declare", "dojo/on", "dojo/has", "put-selector/put", "./List", "dojo/query", "dojo/_base/sniff"],
function(kernel, declare, listen, has, put, List, query){
var contentBoxSizing = has("ie") < 8 && !has("quirks");
var invalidClassChars = /[^\._a-zA-Z0-9-]/g;
function appendIfNode(parent, subNode){
Expand Down Expand Up @@ -39,7 +39,6 @@ function(kernel, declare, listen, has, put, List){
}
var element;
if(target.nodeType){
var object;
do{
if(this._rowIdToObject[target.id]){
break;
Expand All @@ -57,13 +56,7 @@ function(kernel, declare, listen, has, put, List){
var row = this.row(target),
rowElement = row.element;
if(rowElement){
var elements = rowElement.getElementsByTagName("td");
for(var i = 0; i < elements.length; i++){
if(elements[i].columnId == columnId){
element = elements[i];
break;
}
}
element = query('.field-' + columnId, rowElement)[0];
}
}
if(target != null){
Expand All @@ -89,7 +82,6 @@ function(kernel, declare, listen, has, put, List){
// summary:
// Generates the grid for each row (used by renderHeader and and renderRow)
var row = put("table.dgrid-row-table[role=presentation]"),
cellNavigation = this.cellNavigation,
// IE < 9 needs an explicit tbody; other browsers do not
tbody = (has("ie") < 9 || has("quirks")) ? put(row, "tbody") : row,
tr,
Expand Down Expand Up @@ -178,7 +170,6 @@ function(kernel, declare, listen, has, put, List){
// Setup the headers for the grid
var
grid = this,
columns = this.columns,
headerNode = this.headerNode,
i = headerNode.childNodes.length;

Expand Down