Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Several Wine device test fixes #4492

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

WinterSnowfall
Copy link
Contributor

@WinterSnowfall WinterSnowfall commented Nov 25, 2024

WIP to fix several low hanging d3d9-specific Wine device tests. Done.

So far:

  • fixed SRCCOLOR2 & INVSCRCCOLOR2 caps being exposed with non-9Ex devices/interfaces (allegedly only WARP does this)
  • fixed the test_refcount Wine test by preventing device child refcount underruns (we were already doing this in d3d8, thanks to Motor City Online)
  • apply MultiplyTransform state block behavior universally (it is not d3d8 specific)
  • operations on clip planes with an out of bounds index will reflect on the highest valid clip plane
  • add surface format validations to D3D9Surface::GetDC() (note that valid formats still don't seem to work properly here, which might be something we'd want to revisit at some point)
  • fixed a d3d8/d3d9 difference of expected error codes on failed device reset (due to losable resurces)
  • fixed d3d9 state block clearing and recording behavior (the validations work similarly to the system we have in d3d8, but have to be implemented differently due to d3d9 state block implementation differences).

@WinterSnowfall
Copy link
Contributor Author

WinterSnowfall commented Nov 25, 2024

Obligatory indication of progress:

Current master: 0020:device: 154593 tests executed (73 marked as todo, 0 as flaky, 1584 failures), 6 skipped.
This PR: 0020:device: 154308 tests executed (73 marked as todo, 0 as flaky, 845 failures), 6 skipped.

@WinterSnowfall WinterSnowfall force-pushed the d3d9-winetests1 branch 3 times, most recently from d29c25b to db0ed01 Compare November 27, 2024 13:01
@WinterSnowfall WinterSnowfall marked this pull request as ready for review November 27, 2024 17:42
@WinterSnowfall
Copy link
Contributor Author

Gave this PR a round of testing with ~100 d3d9 games and threw in some d3d8 games for good measure (although d3d8 is largely unaffected by these changes). Seems fine.

@WinterSnowfall WinterSnowfall force-pushed the d3d9-winetests1 branch 3 times, most recently from f61a0c5 to bb5b361 Compare November 28, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant