add plan modifier to avoid replacement when there is an update

doitintl · Jan 29, 2024 · 2c5ec41 · 2c5ec41
1 parent 91aa879
commit 2c5ec41
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/examples/main.tf b/examples/main.tf
@@ -6,6 +6,18 @@ terraform {
     }
   }
 }
+resource "doit_attribution" "attri" {
+  name        = "attritestnewname"
+  description = "attritestdesc"
+  formula     = "A"
+  components  = [{ type = "label", key = "iris_region", values = ["us-central1"] }]
+}
+
+resource "doit_attribution_group" "attributeGroup" {
+  name         = "attritestnewgroup"
+  description  = "attritestgroup-new-new"
+  attributions = [doit_attribution.attri.id]
+}
 
 resource "doit_report" "my-report_january" {
   name        = "my-report"
@@ -15,7 +27,7 @@ resource "doit_report" "my-report_january" {
       type  = "basic"
       value = "cost"
     }
-    sort_groups = "asc"
+    sort_groups     = "asc"
     sort_dimensions = "asc"
     advanced_analysis = {
       trending_up   = true

diff --git a/internal/provider/attribution_group_resource.go b/internal/provider/attribution_group_resource.go
@@ -10,6 +10,8 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
@@ -52,6 +54,9 @@ func (r *attributionGroupResource) Schema(ctx context.Context, _ resource.Schema
 			"id": schema.StringAttribute{
 				Description: "Numeric identifier of the attribution group",
 				Computed:    true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.UseStateForUnknown(),
+				},
 			},
 			"last_updated": schema.StringAttribute{
 				Description: "Timestamp of the last Terraform update of" +

diff --git a/internal/provider/attribution_resource.go b/internal/provider/attribution_resource.go
@@ -9,6 +9,8 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
@@ -59,6 +61,9 @@ func (r *attributionResource) Schema(_ context.Context, _ resource.SchemaRequest
 			"id": schema.StringAttribute{
 				Description: "Numeric identifier of the attribution",
 				Computed:    true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.UseStateForUnknown(),
+				},
 			},
 			"last_updated": schema.StringAttribute{
 				Description: "Timestamp of the last Terraform update of" +

diff --git a/internal/provider/report_resource.go b/internal/provider/report_resource.go
@@ -13,7 +13,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64default"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/objectdefault"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
@@ -561,6 +563,9 @@ func (r *reportResource) Schema(_ context.Context, _ resource.SchemaRequest, res
 			"id": schema.StringAttribute{
 				Computed:    true,
 				Description: "Report id",
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.UseStateForUnknown(),
+				},
 			},
 		},
 	}