Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate updating the data #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Apr 9, 2023

every day a minute after midnight + after each
push to master.

Also the data.json is now pretty-printed.

Implements #34

every day a minute after midnight + after each
push to master.

Also the data.json is now pretty-printed.

Implements doitintl#34
@gdubicki
Copy link
Contributor Author

gdubicki commented Apr 9, 2023

Please note that you have to set AWS_KEY_ID and AWS_SECRET_ACCESS_KEY in https://github.com/doitintl/gcpinstances.info project's encrypted secrets. This should be relatively safe as they can't be used in forks.

Also, I haven't really tested the add-and-commit@v9 step so it might need some config tweaking to work.

@Burekasim
Copy link
Collaborator

Thanks.

I would have to comment out the prettifier. The file size after the is much higher and it increase the load time dramatically.

Regarding the environment variable. I'm going to use GitHub oidc provider. So we don't need to use iam keys.

@gdubicki
Copy link
Contributor Author

gdubicki commented Apr 9, 2023

I would have to comment out the prettifier. The file size after the is much higher and it increase the load time dramatically.

Sure, feel free. You can push to my brach or do it any other way you want.

But isn’t the file served compressed with gzip anyway so the size before doesn’t matter?

Regarding the environment variable. I'm going to use GitHub oidc provider. So we don't need to use iam keys.

👌

@gdubicki
Copy link
Contributor Author

gdubicki commented Apr 9, 2023

I checked and data.json is being sent compressed. 700kb before, but below 100kb after compression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants