Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement when using as CMake subproject #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dpurgin
Copy link
Contributor

@dpurgin dpurgin commented Jun 29, 2023

Hi,

here are some changes to CMakeLists:

  • Testing is disabled if Scalr is used as a subproject (it reduces compile/testing time, and normally one would assume the 3rd-party library has been already tested)
  • If Catch2 is not installed system-wide (e.g. on Windows it's 99% the case), fetch if from Github automatically. An error will be produced by FetchContent if it fails.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant