Fix hosting Dolos publicly on https using docker-compose #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdawyndt
reviewed
May 16, 2024
docs/docs/hosting-dolos.md
Outdated
|
|
||
| ::: info | ||
|
|
||
| When hosting the Dolos API **on a subdireectory** (for example: `/api/`) using Docker behind a reverse proxy (**nginx**, **apache**, **haproxy**), there is currently a bug where Rails is generating incorrect URL's not respecting this subdirectory. |
There was a problem hiding this comment.
subdireectory → subdirectory
rien
force-pushed
the
fix/self-hosting-dolos
branch
from
27d0edc
to
5ae29ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Dolos is hosted publicly behind a reverse proxy, Rails does not appropriately detect that HTTPS should be used for urls generated by the API, causing the front-end to fetch the CSV files using http instead of https (see #1518).
This PR fixes this issue by introducing a new environment variable
DOLOS_API_URLwhich is used to detect the hosting properties. It supersedes the environment variablesDOLOS_API_HOSTSandDOLOS_API_DISABLE_FORCE_SSL.Unfortunately there is a bug in rails where files served using ActiveStorage don't listen to the
relative_root_url(rails/rails#43633). This can cause issues if the API is hosted on a subdirectory (https://example.com/api).See #1523 for more details and a workaround.