Remove JQuery #4879
Merged
Remove JQuery #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
approved these changes
Aug 9, 2023
bmesuere
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all remaining usage of jquery. It also removes JQUery as a javascript dependency.
It contains two new helper functions. One avoids code duplication for initializing the correct bootstrap tab.
The other function replaces jquery
replaceWith.I have verified every usage of
$(and$.in our codebase.The only remaining jquery is in the pytutor, which imports it's own jquery.
The impact on the non minimized java script is 0.27 MB.
Old:
New:
Closes #3590