Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introducing option to authenticate with (personal access) token… #27

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

timdeluxe
Copy link
Member

…, instead of username/password

@timdeluxe timdeluxe requested a review from dploeger July 5, 2024 10:59
@timdeluxe timdeluxe self-assigned this Jul 5, 2024
Copy link
Member

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎁

lib/api/Configuration.ts Show resolved Hide resolved
@timdeluxe timdeluxe requested a review from dploeger July 5, 2024 11:54
@timdeluxe
Copy link
Member Author

@dploeger Thanks for the approval, but what about the build failure?

@dploeger
Copy link
Member

@dploeger Thanks for the approval, but what about the build failure?

Ohh, whoops. Didn't see that. Hmm. Interesting. Seems to me as if your changes resulted in changes in the request sent to the mock server in the tests. The mock server holds a list of "expected" requests and returns the response for them. Now there seems to be a new kind of request that isn't in that list. If it's valid, it has to be added.

The log is not really usable in the build failure, maybe run the mocha tests yourself and see the results in your IDE. Then you can check which request doesn't exist in the mock server and see if it's a valid request based on your changes. (maybe even run the tests on main first to see if your changes actually introduced this 😄)

@dploeger dploeger closed this Nov 15, 2024
@dploeger dploeger reopened this Nov 15, 2024
@dploeger dploeger assigned dploeger and unassigned timdeluxe Nov 15, 2024
@dploeger dploeger merged commit deb5c38 into main Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants