-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introducing option to authenticate with (personal access) token… #27
Conversation
…, instead of username/password
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks! 🎁
…, instead of username/password
…, instead of username/password
…, instead of username/password
…, instead of username/password
…, instead of username/password
@dploeger Thanks for the approval, but what about the build failure? |
Ohh, whoops. Didn't see that. Hmm. Interesting. Seems to me as if your changes resulted in changes in the request sent to the mock server in the tests. The mock server holds a list of "expected" requests and returns the response for them. Now there seems to be a new kind of request that isn't in that list. If it's valid, it has to be added. The log is not really usable in the build failure, maybe run the mocha tests yourself and see the results in your IDE. Then you can check which request doesn't exist in the mock server and see if it's a valid request based on your changes. (maybe even run the tests on main first to see if your changes actually introduced this 😄) |
…, instead of username/password