-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added labels to all images #97
Conversation
as required by Artifacthub https://artifacthub.io/docs/topics/repositories/container-images/
Mooo! 🐄 Does the suffix file also work without sending it through mo? This should work for local development on cloudcontrol (not replaced template placeholders shouldn't be an issue for local development). If it does not work, the suffix File should be rather a .mo file (like Dockerfile.suffix.mo), so that one is aware that the Dockerfile.suffix needs to be created first before using it. |
@timdeluxe Yes. You're right. I've modified the workflow a bit to make this more clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎁
@ThomasMinor @timdeluxe Because of a lot of incompatibilities, version unavailabilities etc. this PR now also includes a rewrite of the CCC client in a current Vue version and a changed workflow for installing AWSsudo. :( I hope, it's still review-able. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it is kind of a new software now 😃
But couldn't find bigger issues and i guess you tested it already, so i am fine with it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot for some labels :)
as required by Artifacthub
https://artifacthub.io/docs/topics/repositories/container-images/
I wanted to add CloudControl to the image container registry at Artifacthub, but they require certain labels. Introduced mo to do the dynamic labels in the Dockerfile.suffix