fix: Fixed PATH definition so cloudcontrol.sh finds markdown #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasMinor
approved these changes
Dec 19, 2024
| @@ -42,8 +44,6 @@ then | |||
| markdown < /home/cloudcontrol/.deprecation | |||
There was a problem hiding this comment.
Just a question: Why don't you use the full path here? Then you do not need to adjust the PATH variable.
There was a problem hiding this comment.
The Path variable needs to be adjusted anyway for the basic functionality of cloudcontrol because everything is stored in /home/cloudcontrol/bin. So I just needed to move it up.
| @@ -1,6 +1,6 @@ | |||
| FROM alpine:latest | |||
|
|
|||
| RUN apk add sudo bash curl libc6-compat && \ | |||
| RUN apk add sudo bash curl libc6-compat ca-certificates && \ | |||
There was a problem hiding this comment.
This doesn't fit to the PR title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes fixes because the certificates integration test didn't run sucessfully.