Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat patch #324

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Update compat patch #324

merged 1 commit into from
Jan 12, 2025

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 10, 2025

There must have been upstream changes causing this.
This fixes the build.

@greg0ire greg0ire force-pushed the fix-build branch 11 times, most recently from fdcc5d5 to f3a35bf Compare January 10, 2025 18:24
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#323 was pulling 8.15.0 from Slevomat CS.

Maybe running the tests as a cronjob every month would help to reduce unrelated build failings in PRs.

@SenseException
Copy link
Member

There's already a cronjob 🤔
https://github.com/doctrine/coding-standard/blob/12.0.x/.github/workflows/continuous-integration.yml#L11

@greg0ire greg0ire merged commit 2b558dd into doctrine:12.0.x Jan 12, 2025
14 checks passed
@greg0ire greg0ire deleted the fix-build branch January 12, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants