Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laminas-servicemanager v4 support #754

Open
wants to merge 1 commit into
base: 6.2.x
Choose a base branch
from

Conversation

samsonasik
Copy link
Contributor

No description provided.

@samsonasik
Copy link
Contributor Author

another dependency seems use laminas-servicemanager v3, as run on php 8.3 got:

  - Installing laminas/laminas-servicemanager (3.22.1): Extracting archive

@samsonasik
Copy link
Contributor Author

I see, doctrine/doctrine-module still require v3 only.

https://github.com/doctrine/DoctrineModule/blob/905d493770193f14f19b60998de9993a3dfde5f9/composer.json#L58

@samsonasik
Copy link
Contributor Author

Ref doctrine/DoctrineModule#835

@TomHAnderson
Copy link
Member

That's correct. A large refactor of this project is in order but we need to wait for Laminas to catch up their own libraries before we can continue. e.g. we need version 4 of https://github.com/laminas/laminas-cache

@dkmuir
Copy link

dkmuir commented May 20, 2024

@TomHAnderson Couldn't DoctrineORMModule be decoupled from laminas-cache? Especially since any PSR-6 adapter will do now? We migrated to Symfony's cache a few months ago as it was looking at the time that laminas-cache going stagnant and couldn't be readily relied upon long term.

@TomHAnderson
Copy link
Member

@dkmuir thanks for the news. The Laminas, and ZF2 library before, pull from the resources available within the framework. In that case, it would be laminas/laminas-cache. It is news to me that this project is dying. I am for using PSR standards as applicable. But does that mean we should code against PSR-11 instead of laminas/laminas-servicemanager?

I'll consult with the team.

@dkmuir
Copy link

dkmuir commented May 20, 2024

@TomHAnderson I don't think it actually is dying. I just had a look through the last year's worth of steering committee minutes, and can't find anything... Really not sure how I got that in my head... 😬

With the question of decoupling ServiceManager... I don't think it makes much sense. For those who need it, wouldn't https://github.com/Roave/psr-container-doctrine already fit the bill?

@samsonasik
Copy link
Contributor Author

laminas-cache already v4 which support laminas-servicemanager v4 https://github.com/laminas/laminas-cache/releases/tag/4.0.4

@SenseException
Copy link
Member

The checks have passed but the logs are already gone. I'm closing and reopening this PR to trigger the workflows again. I want to be sure that some checks with the "highest" setting are installing 4.0 and "lowest" 3.17.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 3.22.1 is the highest version we get for laminas/laminas-servicemanager. Some other packages are preventing the installation of 4.x

@TomHAnderson
Copy link
Member

4.x is blocked by many Laminas modules. Detailed here: doctrine/DoctrineModule#834

I've been planning on a significant upgrades to the Laminas modules but the pace of development at Laminas is slow and getting an installable set of libraries to do this upgrade is not possible at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants