Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #275

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Update README.md #275

merged 1 commit into from
Dec 12, 2023

Conversation

A5yncX
Copy link
Contributor

@A5yncX A5yncX commented Dec 12, 2023

Add theme Darcula.

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A5yncX , thx for you brilliant theme contribution!

I checked the links of this project, I think there needs some refinements.
Considering publish the style resources would benefit users who wanna use it.

They could use a simple import like

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsify-theme-darcula/dist/css/darcula.css">

And then, a docsify-darcula-template would come naturally either.

@A5yncX
Copy link
Contributor Author

A5yncX commented Dec 12, 2023

Hi @A5yncX , thx for you brilliant theme contribution!

I checked the links of this project, I think there needs some refinements. Considering publish the style resources would benefit users who wanna use it.

They could use a simple import like

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsify-theme-darcula/dist/css/darcula.css">

And then, a docsify-darcula-template would come naturally either.

Hi @Koooooo-7 , for some people who want to be different, they prefer to be able to modify any css, which is why I store css files like this. But what you said makes sense, I will give the CDN link in README.md

@A5yncX
Copy link
Contributor Author

A5yncX commented Dec 12, 2023

I added it ;)

<link rel="stylesheet" href="https://cdn.jsdelivr.net/gh/A5yncX/[email protected]/darcula.css">

@A5yncX A5yncX requested a review from Koooooo-7 December 12, 2023 09:10
@Koooooo-7 Koooooo-7 merged commit bade937 into docsifyjs:master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants