-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement summary bars for feature attributes #21667
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is looking really great @sarahsanders-docker. I have a few thinking-out-loud comments:
|
This is looking great! Liking this next iteration. |
@aevesdocker In my notes from the Docs huddle feedback, we said it didn't make sense to only reference persona sometimes. If we are tagging docs with an Admin persona, would we have to then tag docs with a Developer persona? Or create additional personas? Happy to bring the discussion back these week in huddle if we should talk through it again |
I think it's worth having the option to add an item to say that specific pages are targeted at Administrators. And I don't think we'd have to tag other pages with the developer or other personas, we'd just leave that item out. It doesn't need to be an all or nothing thing. |
09677f6
to
017d716
Compare
1004c93
to
71e5562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look, left some suggestions on how I would approach this. Note: I haven't actually run the code I wrote here so there might be an error somewhere, but I hope it captures the idea. Let me know what you think or if you need more guidance.
4b89b08
to
405e247
Compare
9185089
to
fc93712
Compare
fc93712
to
c7ddeca
Compare
Description
summary-bar.html
shortcodeRelated issues or tickets
Reviews
Preview: https://deploy-preview-21667--docsdocker.netlify.app/security/for-admins/hardened-desktop/settings-management/configure-admin-console/