Gofumpt all the things #12392
Merged
Gofumpt all the things #12392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format the code with gofumpt to prevent my IDE from reformatting every time I open a file. gofumpt provides a superset of gofmt, so should not impact users that are not using gofumpt. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
gofumpt_all_the_things
branch
from
b2c4389 to
50f2f54
Compare
glours
approved these changes
Dec 17, 2024
thaJeztah
reviewed
Dec 17, 2024
.github/workflows/ci.yml
Outdated
| @@ -50,6 +50,7 @@ jobs: | |||
| - validate-go-mod | |||
| - validate-headers | |||
| - validate-docs | |||
| - validate-fmt | |||
There was a problem hiding this comment.
FWIW; there's a golangci-lint linter for gofumpt; https://golangci-lint.run/usage/linters/#gofumpt
There was a problem hiding this comment.
nice, makes things even simpler
ndeloof
force-pushed
the
gofumpt_all_the_things
branch
from
57b9d9b to
0c7adab
Compare
|
Thanks! I started to add the same logic as we had in docker/cli in the Makefile, which does a "optimistic" try to see if |
ndeloof
force-pushed
the
gofumpt_all_the_things
branch
from
0c7adab to
38b61a1
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
gofumpt_all_the_things
branch
from
38b61a1 to
9aec80b
Compare
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #12365 + make target