Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail start if depependency is missing #11110

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 19, 2023

What I did
as we wait for dependencies, if no container is found fail or warn user. This should never happen using up as convergence created the dependencies in order.

Related issue
closes #11107

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team October 19, 2023 07:32
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fd8ab2f) 58.81% compared to head (662f8b4) 57.56%.
Report is 110 commits behind head on main.

❗ Current head 662f8b4 differs from pull request most recent head 1ffa194. Consider uploading reports for the commit 1ffa194 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11110      +/-   ##
==========================================
- Coverage   58.81%   57.56%   -1.25%     
==========================================
  Files         120      129       +9     
  Lines       10454    11274     +820     
==========================================
+ Hits         6148     6490     +342     
- Misses       3706     4154     +448     
- Partials      600      630      +30     
Files Coverage Δ
pkg/compose/run.go 55.04% <100.00%> (-0.41%) ⬇️
pkg/compose/start.go 62.34% <100.00%> (-3.09%) ⬇️
pkg/compose/convergence.go 70.92% <66.66%> (+1.30%) ⬆️

... and 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit b8773ad into docker:main Oct 19, 2023
22 checks passed
@ndeloof ndeloof deleted the wait_missing branch December 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Endless start of containers
2 participants