move watch from alpha to main command #11021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Sep 19, 2023
ndeloof
approved these changes
Sep 20, 2023
cmd/compose/alpha.go
Outdated
| @@ -31,7 +31,6 @@ func alphaCommand(p *ProjectOptions, dockerCli command.Cli, backend api.Service) | |||
| }, | |||
| } | |||
| cmd.AddCommand( | |||
| watchCommand(p, dockerCli, backend), | |||
There was a problem hiding this comment.
shall we (temporary) keep this alpha command with a warning for user to adopt the official one ?
glours
force-pushed
the
move-watch-to-main-cmd
branch
3 times, most recently
from
00fc23e to
cce8434
Compare
ndeloof
approved these changes
Sep 20, 2023
glours
force-pushed
the
move-watch-to-main-cmd
branch
from
cce8434 to
24977a1
Compare
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
move-watch-to-main-cmd
branch
from
24977a1 to
6be5f30
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11021 +/- ##
==========================================
+ Coverage 57.38% 57.43% +0.04%
==========================================
Files 129 129
Lines 11227 11229 +2
==========================================
+ Hits 6443 6449 +6
+ Misses 4151 4147 -4
Partials 633 633
☔ View full report in Codecov by Sentry. |
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Move
watchcommand away from thealphacmd umbrellaRelated issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
