don't rely on depends_on to resolve volume_from, better use observed state #10999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
no-deps-volume-from
branch
from
6eefef3 to
81b8ba6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10999 +/- ##
==========================================
+ Coverage 57.88% 57.95% +0.07%
==========================================
Files 129 129
Lines 11160 11108 -52
==========================================
- Hits 6460 6438 -22
+ Misses 4063 4038 -25
+ Partials 637 632 -5
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
no-deps-volume-from
branch
2 times, most recently
from
ad3dc84 to
bf961a9
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
glours
approved these changes
Sep 14, 2023
…state Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
no-deps-volume-from
branch
2 times, most recently
from
273c702 to
e2aa036
Compare
milas
approved these changes
Sep 14, 2023
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
no-deps-volume-from
branch
from
e2aa036 to
92637d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
remove preemptive parsing of
volumes_fromdoing convergence based on known dependencies, better rely on observed state to select target container. This also removes the assumption we will be able to use container number1Related issue
closes #10996
closes #10997
(not mandatory) A picture of a cute animal, if possible in relation to what you did