cli/command/registry: assorted refactor and test changes #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be more explicit on not returning a response if there was an error; change some non-exported functions to return a pointer, and return nil instead. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function only needs the API client, not all of the CLI. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function only needs access to the configfile Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
- also check errors that were previously not handled - use the fakeCLI's buffer instead of creating one manually Signed-off-by: Sebastiaan van Stijn <[email protected]>
Various functions were passing through the API response as a whole, but effectively only needed it for a status message (if any). Reduce what's returned to only the message. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
commented
Dec 4, 2024
| } | ||
| return nil | ||
| } | ||
|
|
||
| func loginWithStoredCredentials(ctx context.Context, dockerCli command.Cli, authConfig registrytypes.AuthConfig) (*registrytypes.AuthenticateOKBody, error) { | ||
| func loginWithStoredCredentials(ctx context.Context, dockerCli command.Cli, authConfig registrytypes.AuthConfig) (msg string, _ error) { |
There was a problem hiding this comment.
I was going back and forth a bit whether we'd ever would need more from the response returned here, but as we currently don't use anything from that (and these functions already handle the response and store it), as well as these being non-exported, I thought perhaps it's good to just return the thing we need and considering this a good hand-over point for API types to local information.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 59.53% 59.49% -0.04%
==========================================
Files 346 346
Lines 29356 29358 +2
==========================================
- Hits 17477 17468 -9
- Misses 10909 10918 +9
- Partials 970 972 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/registry: don't return creds on error
Be more explicit on not returning a response if there was an error;
change some non-exported functions to return a pointer, and return
nil instead.
cli/command/registry: loginWithRegistry: use shallower interface
This function only needs the API client, not all of the CLI.
cli/command/registry: storeCredentials: accept configfile as arg
This function only needs access to the configfile
cli/command/registry: TestLoginWithCredStoreCreds slight refactor
cli/command/registry: return status only instead of whole response
Various functions were passing through the API response as a whole, but
effectively only needed it for a status message (if any). Reduce what's
returned to only the message.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)