Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ip-forward-no-drop to dockerd cmdline ref #5598

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

robmry
Copy link
Contributor

@robmry robmry commented Nov 6, 2024

- What I did

Added new --ip-forward-no-drop to the command line ref, and updated the description for --ip-forward.

- How I did it

- How to verify it

- Description for the changelog

n/a

@robmry robmry added this to the 28.0.0 milestone Nov 6, 2024
@robmry robmry self-assigned this Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (2369935) to head (1911ded).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5598   +/-   ##
=======================================
  Coverage   59.50%   59.50%           
=======================================
  Files         346      346           
  Lines       29369    29369           
=======================================
  Hits        17475    17475           
  Misses      10920    10920           
  Partials      974      974           

@robmry robmry force-pushed the dockerd-cmd-ref-ipffd branch from 64455c7 to 038d3ea Compare November 7, 2024 16:13
@robmry robmry changed the title Add --ip-filter-forward-drop to dockerd cmdline ref Add --ip-forward-no-drop to dockerd cmdline ref Nov 7, 2024
@robmry robmry marked this pull request as ready for review November 25, 2024 19:54
@robmry robmry requested review from thaJeztah and a team as code owners November 25, 2024 19:54
@thaJeztah
Copy link
Member

Oh! Forgot that in your previous PR (merged that one and facepalmed after); this repository still has a copy of the man page as well, and we haven't updated our packaging pipeline yet, so still use this one for our packages; can you port over the related man page changes as well? https://github.com/docker/cli/blob/master/man/dockerd.8.md

Added to the dockerd cmdline ref and its manpage.

Signed-off-by: Rob Murray <[email protected]>
@robmry robmry force-pushed the dockerd-cmd-ref-ipffd branch from 038d3ea to 1911ded Compare November 29, 2024 12:18
@robmry
Copy link
Contributor Author

robmry commented Nov 29, 2024

can you port over the related man page changes as well?

Ah, right - thank you ... I've added it to the commit. I'll look at the other changes too.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 083495c into docker:master Nov 29, 2024
92 checks passed
@robmry robmry deleted the dockerd-cmd-ref-ipffd branch November 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants