Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add test for HeaderFunctions #5541

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

thaJeztah
Copy link
Member

Before:

go test -test.coverprofile -
PASS
coverage: 65.2% of statements
ok  	github.com/docker/cli/templates	0.607s

After:

go test -test.coverprofile -
PASS
coverage: 95.7% of statements
ok  	github.com/docker/cli/templates	0.259s

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (3590f94) to head (12dcc6e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5541      +/-   ##
==========================================
- Coverage   60.92%   59.54%   -1.39%     
==========================================
  Files         345      345              
  Lines       23491    29090    +5599     
==========================================
+ Hits        14313    17322    +3009     
- Misses       8205    10795    +2590     
  Partials      973      973              

@thaJeztah thaJeztah requested a review from a team October 17, 2024 23:36
templates/templates_test.go Show resolved Hide resolved
templates/templates_test.go Show resolved Hide resolved
Before:

    go test -test.coverprofile -
    PASS
    coverage: 65.2% of statements
    ok  	github.com/docker/cli/templates	0.607s

After:

    go test -test.coverprofile -
    PASS
    coverage: 95.7% of statements
    ok  	github.com/docker/cli/templates	0.259s

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah merged commit da9e984 into docker:master Oct 18, 2024
89 checks passed
@thaJeztah thaJeztah deleted the template_coverage branch October 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants