Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update prose about image tag/name format #5535

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 14, 2024

- What I did

Update the verbiage about the format of image tags/names.

- How I did it

/usr/bin/nvim

- How to verify it

read it

- A picture of a cute animal (not mandatory but encouraged)

@dvdksn dvdksn requested review from thaJeztah and a team as code owners October 14, 2024 14:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (6ed137f) to head (2c6b804).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5535      +/-   ##
==========================================
+ Coverage   60.67%   60.92%   +0.25%     
==========================================
  Files         345      345              
  Lines       23491    23491              
==========================================
+ Hits        14252    14313      +61     
+ Misses       8266     8205      -61     
  Partials      973      973              

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Thanks 🤗

@dvdksn dvdksn force-pushed the fix-image-tag-spec branch from 389dc26 to a1ca594 Compare October 14, 2024 17:33
Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.. Maybe we should use the term image reference instead of image name?

docs/reference/commandline/image_tag.md Outdated Show resolved Hide resolved
docs/reference/commandline/image_tag.md Outdated Show resolved Hide resolved
@dvdksn dvdksn force-pushed the fix-image-tag-spec branch from a1ca594 to 2c6b804 Compare October 17, 2024 10:36
Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vvoland vvoland merged commit 3590f94 into docker:master Oct 17, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants